Convert LayoutGridField to function components #4807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "homepage": "https://github.com/rjsf-team/react-jsonschema-form", | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, |
…form into layout-grid-fn
LayoutGridField: - Deep compare memoize the fieldPathId - Move helper functions in LayoutGridField - Update docs comments in LayoutGridField - Attach TEST_IDS to LayoutGridField function Additionally: - Update migration guide per rjsf-team#4808
heath-freenome
approved these changes
Oct 19, 2025
| } = getSchemaDetailsForField<T, S, F>(registry, name, initialSchema, formData, fieldPathId); | ||
| const memoFieldPathId = useDeepCompareMemo<FieldPathId>(fieldIdSchema); | ||
|
|
||
| if (uiComponentProps.rendered) { |
There was a problem hiding this comment.
It kind of sucks that the rules of hooks forces us to call that rather expensive getSchemaDetailsForField() first
- Move LayoutGridFieldChildren component definition above usage - LayoutGridFieldComponent": Simplify props destructure - Fix issue with the nx dependency graph - dependencies were not tracked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Convert the LayoutGridField into function components
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.